Skip to content

Conversation

@comphead
Copy link
Contributor

@comphead comphead commented Jan 7, 2026

Which issue does this PR close?

Closes #3046 .

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 9.97%. Comparing base (f09f8af) to head (38b4ce7).
⚠️ Report is 832 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #3052       +/-   ##
============================================
- Coverage     56.12%   9.97%   -46.16%     
+ Complexity      976     234      -742     
============================================
  Files           119     167       +48     
  Lines         11743   15508     +3765     
  Branches       2251    2549      +298     
============================================
- Hits           6591    1547     -5044     
- Misses         4012   13784     +9772     
+ Partials       1140     177      -963     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

file_source,
)
.with_projection_indices(Some(projection_vector))
.with_table_partition_cols(partition_fields)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make_decimal_scalar(a, precision, scale, &f)
}
ScalarValue::Float32(_) | ScalarValue::Float64(_) => Ok(ColumnarValue::Scalar(
ScalarValue::try_from_array(&round(&[a.to_array()?, args[1].to_array(1)?])?, 0)?,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the direct function is private now, creating UDF instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataFusion 52 migration

2 participants