Added missing From impls for Statement variants
#2160
+275
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jan 13, 2026
| or_replace: bool, | ||
| temporary: bool, | ||
| ) -> Result<Statement, ParserError> { | ||
| ) -> Result<CreateFunction, ParserError> { |
Contributor
There was a problem hiding this comment.
Not sure I followed the intent of this diff - we're changing the public APIs to return not an actual statement anymore but its not clear to me why that's a desirable change?
Contributor
Author
There was a problem hiding this comment.
I made it so all of these type of function return the strictest concrete variant, which is the thing they actually return, so that in practice one can write:
let my_specific_variant = parse_my_specific_variant(...)?instead of:
let Statement::MySpecificVariant(my_specific_variant) = parse_my_specific_variant(...)? else {
unreachable!();
};which seems much cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my last PR adding the missing
Fromimpls forStatementenum variants to convert any given variantXintoStatement::X(X)using theFromtrait, several suchXvariants have been added without the associatedFromimpl.This PR adds several (I hope all) missing
Fromimpls, and reasonably cleans up some of the code which was using the more verbose conversion.Luca