Skip to content

fix: custom nullability for spark rint #19256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ANISH-SR wants to merge 1 commit into from
Closed

fix: custom nullability for spark rint #19256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions datafusion/spark/src/function/math/rint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ use arrow::datatypes::DataType::{
Float32, Float64, Int16, Int32, Int64, Int8, UInt16, UInt32, UInt64, UInt8,
};
use arrow::datatypes::{DataType, Float32Type, Float64Type};
use datafusion_common::{assert_eq_or_internal_err, exec_err, Result};
use datafusion_common::{assert_eq_or_internal_err, exec_err, internal_err, Result};
use datafusion_expr::sort_properties::{ExprProperties, SortProperties};
use datafusion_expr::{
ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, Signature, Volatility,
ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDFImpl, Signature,
Volatility,
};
use datafusion_functions::utils::make_scalar_function;

Expand Down Expand Up @@ -64,7 +65,26 @@ impl ScalarUDFImpl for SparkRint {
}

fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
Ok(Float64)
internal_err!(
"return_type should not be called, use return_field_from_args instead"
)
}

fn return_field_from_args(
&self,
args: ReturnFieldArgs,
) -> Result<arrow::datatypes::FieldRef> {
let nullable = args
.arg_fields
.get(0)
.map(|f| f.is_nullable())
.unwrap_or(true);

Ok(Arc::new(arrow::datatypes::Field::new(
self.name(),
Float64,
nullable,
)))
}

fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> {
Expand Down
Loading