Improve ProjectionExpr documentation and comments #19263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
commented
Dec 10, 2025
| // This is what the physicalfile schema is coerced to. | ||
| // - The physical file schema: this is the schema as defined by the parquet file. This is what the parquet file actually contains. | ||
| // This is what the physical file schema is coerced to. | ||
| // - The physical file schema: this is the schema that the arrow-rs |
Contributor
Author
There was a problem hiding this comment.
I found the "what the file contains" confusing -- Parquet has different datatypes than Arrow
adriangb
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While reviewing #19111 from @adriangb I found a few places that the documentation could be improved to give higher level context
What changes are included in this PR?
Update some docs and comments
Are these changes tested?
By cos
Are there any user-facing changes?
Just docs/comments. No functional changes