Skip to content

Conversation

@JSOD11
Copy link

@JSOD11 JSOD11 commented Dec 10, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the spark label Dec 10, 2025
@kumarUjjawal
Copy link
Contributor

@JSOD11 Please add unit test for all your changes.

@JSOD11 JSOD11 force-pushed the jsod/modulus-custom-nullability-12-10-25 branch from 7c1a30b to e43e744 Compare December 12, 2025 18:55
@JSOD11 JSOD11 marked this pull request as ready for review December 12, 2025 18:56
@kumarUjjawal
Copy link
Contributor

kumarUjjawal commented Dec 13, 2025

Can we do something like this

fn return_field_for_binary_op(
    name: &str,
    args: ReturnFieldArgs,
) -> Result<FieldRef> {
    let any_nullable = args.arg_fields.iter().any(|f| f.is_nullable());
    let data_type = args.arg_fields[0].data_type().clone();
    Ok(Arc::new(Field::new(name, data_type, any_nullable)))
}

And use in both the return_field_from_args functions to improve maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spark modulus need to have custom nullability

3 participants