Repository navigation
branch-4.2: [chore](docker)Support rootless Docker for third-party environments #70457 - #70580
Open
morningman wants to merge 2 commits into
Open
morningman wants to merge 2 commits into
morningman wants to merge 2 commits into
Conversation
…pache#70457) Allow non-root users to start third-party test environments with rootless Docker. Remove host privilege escalation and adapt file ownership, networking, initialization, and health checks. Linux now requires a rootless daemon. --------- Co-authored-by: Dongyang Li <lidongyang@selectdb.com>Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bp #70457
Conflict resolution for branch-4.2
#70457 does not apply cleanly here: it builds on launcher wrappers that master got from #64304, and it touches the Fluss fixture, which branch-4.2 does not have. What differs from the original:
docker-compose/fluss/README.mdandfluss.env.tplstay deleted,fluss-network.shandtest/fluss-network-test.share left out, and the Fluss sentence indocker/thirdparties/README.mdand the Fluss case intest/launcher-stop-test.share dropped.run-thirdparties-docker.sh: branch-4.2 had nodocker_cli/host_admin_cmdwrappers, so besides the conflicted hunks, the 21 remainingsudo dockercalls becomedocker_cli(as on master), the Lance jar download and the Iceberg data extraction dropsudo, and LakeSoul'ssudo rm -rf databecomesreset_data_dirsplusrmdir, the pattern [chore](docker)Support rootless Docker for third-party environments #70457 uses for Iceberg.iceberg-restis added toALL_COMPONENTS. Master-only code (Fluss, the Iceberg jar check) is not added; MongoDB exists on branch-4.2 and takes [chore](docker)Support rootless Docker for third-party environments #70457's change. The launcher has nosudoleft.ranger_settings.env: takes [chore](docker)Support rootless Docker for third-party environments #70457's overridable form. This also renames branch-4.2'sRANGER_SOLAR_PORTtoRANGER_SOLR_PORT, the nameranger.yaml.tplalready reads (master fixed it in [feat](authorization) introduce an authorization plugin SPI and move the Ranger sources out of fe-core #66770).test/launcher-stop-test.sh: branch-4.2'scustom_settings.envsetsCONTAINER_UIDunconditionally, so the test rewrites the copied file the way CI does.The other 25 files carry #70457's changes unchanged.
Testing
bash -npasses on everydocker/thirdparties/*.sh.test/docker-command-test.sh,test/snapshot-hive-baseline-test.shandtest/launcher-stop-test.shpass locally (macOS, bash 5.3, GNU getopt as on Linux CI); the stop test fails when theSTOPguard on Hive data preparation is removed.TeamCity/externalrequired here.AI Disclosure