fix: fix night ci failure #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates utility class imports by replacing duplicate imports with centralized versions from the common.util package and removes unused/duplicate utility files.
Changes:
- Replaced 9 imports of ListUtils from sheet.util package with imports from common.util package
- Removed duplicate StyleTestUtils.java from fesod-examples (main copy remains in fesod-sheet)
- Removed unused ValidateUtils.java and its test file from fesod-common
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ReadTest.java | Updated ListUtils import from sheet.util to common.util |
| NoModelDataListener.java | Updated ListUtils import from sheet.util to common.util |
| IndexOrNameDataListener.java | Updated ListUtils import from sheet.util to common.util |
| DemoHeadDataListener.java | Updated ListUtils import from sheet.util to common.util |
| DemoExceptionListener.java | Updated ListUtils import from sheet.util to common.util |
| DemoDataListener.java | Updated ListUtils import from sheet.util to common.util |
| DemoCompatibleHeaderDataListener.java | Updated ListUtils import from sheet.util to common.util |
| ConverterDataListener.java | Updated ListUtils import from sheet.util to common.util |
| CellDataDemoHeadDataListener.java | Updated ListUtils import from sheet.util to common.util |
| StyleTestUtils.java | Removed duplicate test utility from fesod-examples |
| ValidateUtils.java | Removed unused utility class from fesod-common |
| ValidateUtilsTest.java | Removed test for deleted ValidateUtils class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GOODBOY008
force-pushed
the
refactor/fix-example-failure
branch
from
07a7560 to
2ad61ab
Compare
GOODBOY008
changed the title
Member
Author
|
@delei PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.