Skip to content

Conversation

@Akshat-Soni02
Copy link

Description

Implemented missing status mappings for savings and share entities in the SearchMapper to ensure accurate and complete search results.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to do a squash and commit. Are you proposing to look up by the internal ID?

@Akshat-Soni02
Copy link
Author

Make sure to do a squash and commit. Are you proposing to look up by the internal ID?

I’m not directly using the internal status ID.
I’m following the same pattern used for loan and client:
using SavingsEnumerations , SharesEnumerations

@Akshat-Soni02 Akshat-Soni02 force-pushed the fineract-2408/search-api-for-savings branch from bc62c6b to a34c455 Compare November 20, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants