Skip to content

Conversation

@rajuyadav03
Copy link

What’s Changed?

This PR removes commented lines (# and <!-- -->) from auto-generated Git commit messages, ensuring the commit history is clean and readable.

Fixes

Hi! I’m participating in Hacktoberfest 2025.
Please add the hacktoberfest-accepted label if appropriate. Thanks!

@rajuyadav03
Copy link
Author

Hi! This PR removes commented lines from auto-generated Git commit messages — hacktoberfest-accepted label would be awesome!

@chaokunyang
Copy link
Collaborator

Hi @rajuyadav03 , thanks for contributing to Apache Fory. To remove commented content, you may also need to update github workflow too. And invoke scripts/remove-commented-commit.sh in the github ci workflow

@rajuyadav03

This comment was marked as resolved.

@rajuyadav03
Copy link
Author

Thanks — I’ve added the workflow change to invoke scripts/remove-commented-commit.sh.
The workflow now gets the last commit message, runs the script, and prints the cleaned message in CI logs.
Please let me know if you want the job to do anything else

@chaokunyang
Copy link
Collaborator

@rajuyadav03 have you verified that this PR works? you can open a pull request in your forked repository, and merge it into main branch, then open another PR to see whether it works

@rajuyadav03
Copy link
Author

I verified the changes by merging them into my fork’s main and opening a PR to apache/fory. The CI checks for that PR passed: [link to PR]. Please let me know if you want any additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove commented content in git commit message

2 participants