[GLUTEN-12462][CORE] Expose shuffle reader metrics iterator delegate#12587
Merged
Conversation
taiyang-li
marked this pull request as draft
July 21, 2026 08:43
taiyang-li
force-pushed
the
shuffle_delegate
branch
from
July 21, 2026 08:43
e502b28 to
f6269a8
Compare
taiyang-li
marked this pull request as ready for review
July 21, 2026 08:44
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
WangGuangxin
approved these changes
Jul 21, 2026
marin-ma
approved these changes
Jul 21, 2026
marin-ma
left a comment
marin-ma
left a comment
Contributor
There was a problem hiding this comment.
@taiyang-li Sorry for the unintentional change. Thank you for following up!
Member
|
@taiyang-li we are trying to refactor shuffle for gpu execution, will tag you on the following refactor PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
One of a small series of common-code changes to introduce a new backend — Bolt (ByteDance’s unified lakehouse analytics acceleration engine) — into the Gluten community. The series minimizes the delta to Gluten common code so Bolt can plug in cleanly, while leaving Velox and ClickHouse backends unaffected. It is part of plan in #12456, close #12462
This PR
Refactor the anonymous
mapinsideShuffledColumnarBatchRDD.computeinto a named classShuffleReaderWithMetricsIteratorthat exposes the underlying shuffle-read iterator via a publicdelegatefield. Per-batch semantics are preserved: for every batch we still callSQLColumnarShuffleReadMetricsReporter.incBatchesRecordsRead(numRows)and return the batch.The Bolt backend needs to unwrap the underlying
Iterator[Product2[Int, ColumnarBatch]]for additional post-processing after the shuffle read. Giving the wrapper a stable name and adelegateaccessor lets that be done without duplicating the entirecompute()path.Note: the same patch I created before(#12432) had been deleted by #12511 cc @marin-ma. So I create it again...