Repository navigation
fix(forge): keep the Grails Data plugin off the generated buildscript classpath - #16575
Merged
Merged
Conversation
borinquenkid
requested review from
jamesfredley and
jdaugherty
and
a balanced review from Copilot
October 10, 2026 19:57
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 9.0.x #16575 +/- ##
==================================================
- Coverage 60.9953% 60.9855% -0.0099%
+ Complexity 26642 26640 -2
==================================================
Files 2249 2249
Lines 111561 111561
Branches 20207 20207
==================================================
- Hits 68047 68036 -11
- Misses 34527 34537 +10
- Partials 8987 8988 +1 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
jdaugherty
added a commit
that referenced
this pull request
Oct 16, 2026
…ert buildSrc still renders, reword the feature comments
… classpath Generated builds declared grails-data-hibernate5/7 as a buildscript classpath entry (and a buildSrc implementation dependency), a leftover from when the CLI found plugin commands through the build classpath; commands now ship in the companion -cli artifacts the Grails Gradle plugin discovers from the application's dependencies. The plugin pulls in grails-datamapping-core, which registers global AST transformations, so Gradle's embedded Groovy 4 ran them while compiling build.gradle. With the transformations now compiled by Groovy 6 that fails at configuration time (NoSuchMethodError NumberMath.remainder, Build Grails Forge job: CreateDomainClassCommandSpec and the other command specs); with the Java-compiled transformations it merely ran them for nothing. The plugin stays an application dependency only. The upgrade guide tells existing builds to drop the classpath entry and names the symptom. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> (cherry picked from commit 7322d81)
…or, place the What's New note with it, assert buildSrc still renders, reword the feature comments
jdaugherty
force-pushed
the
fix/forge-grails-data-buildscript-classpath
branch
from
October 16, 2026 16:36
945b132 to
71a64db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Grails Forge no longer adds
grails-data-hibernate5/grails-data-hibernate7to the generatedbuild.gradlebuildscriptclasspath (nor tobuildSrc). The plugin stays an ordinary application dependency.GrailsDataHibernate5/7features and their specs are updated;whatsNewand the 8.0.x upgrade guide (§86) gain a note telling existing builds to drop the entry.Why
The entry was a leftover from when the CLI found a plugin's commands through the build classpath; commands now ship in companion
-cliartifacts that the Grails Gradle plugin discovers from the application's dependencies. With the plugin on thebuildscriptclasspath,grails-datamapping-core's global AST transformations run inside the Groovy that Gradle embeds while compilingbuild.gradle; once those transformations are compiled by Groovy 6 that fails at configuration time (NoSuchMethodError ... NumberMath.remainder, seen in the Build Grails Forge job:CreateDomainClassCommandSpecand the other command specs).This is independent of the Java-to-Groovy migration (#16351) but surfaced while splitting it. The buildscript entry has been generated since 8.0.x and the Grails Gradle plugin on every 8.x branch already discovers commands from the application's dependencies, so the fix targets
8.0.xand merges up.Verification
🤖 Generated with Claude Code