-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29794 Only exclude tests when its failure rate above a threshold #7574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+29
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ndimiduk
approved these changes
Dec 22, 2025
guluo2016
reviewed
Dec 22, 2025
| for build in build_id_to_results: | ||
| [all_tests, failed_tests, timeout_tests, hanging_tests] = build_id_to_results[build] | ||
| for bad_test in test_to_build_ids: | ||
| for bad_test, test_result in test_to_build_ids: |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use test_to_build_ids.items() to iterate over the dict's key-value
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
guluo2016
approved these changes
Dec 22, 2025
Apache9
added a commit
that referenced
this pull request
Dec 22, 2025
#7574) Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Peng Lu <[email protected]> (cherry picked from commit 1c2025c)
Apache9
added a commit
that referenced
this pull request
Dec 22, 2025
#7574) Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Peng Lu <[email protected]> (cherry picked from commit 1c2025c)
Apache9
added a commit
that referenced
this pull request
Dec 22, 2025
#7574) Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Peng Lu <[email protected]> (cherry picked from commit 1c2025c)
Apache9
added a commit
that referenced
this pull request
Dec 22, 2025
#7574) Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Peng Lu <[email protected]> (cherry picked from commit 1c2025c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.