PoolingHttpClientConnectionManager: Re-set socket timeout from SocketConfig upon lease #785
+27
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschmitt
force-pushed
the
reset-soTimeout
branch
from
8075859 to
8c2515e
Compare
…Config upon lease This change fixes a bug in the synchronous client where socket timeouts were not being set correctly on reused TLS connections. It also changes the existing socket timeout tests to ensure that the various read and socket timeout configs are respected in the context of connection reuse. See also apache@57423c0
rschmitt
force-pushed
the
reset-soTimeout
branch
from
8c2515e to
5b58b6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in the synchronous client where socket timeouts were not being set correctly on reused TLS connections. It also changes the existing socket timeout tests to ensure that the various read and socket timeout configs are respected in the context of connection reuse.
See also 57423c0