Optimize TsTable with Copy-on-Write pattern for thread-safe concurrent access #17069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t access - Change columnSchemaMap, tagColumnIndexMap, and idColumnIndexMap from final to volatile - Implement Copy-on-Write in executeWrite method: 1. Create local copies of maps before modification 2. Execute write operations on local copies 3. Atomically update class fields after write completes - Add WriteOperation functional interface to pass map copies to write operations - Add executeWriteWithTransform for efficient single-pass transformation during copy - Optimize renameColumnSchema to preserve column order with single-pass copy - This ensures readers see either complete old data or complete new data, avoiding ConcurrentModificationException
luoluoyuyu
force-pushed
the
fix-table-schema
branch
from
05514ac to
9b221b1
Compare
jt2594838
approved these changes
Jan 26, 2026
jt2594838
reviewed
Jan 26, 2026
Comment on lines
+170
to
+173
| // After write completes, atomically update the class fields | ||
| columnSchemaMap = newColumnSchemaMap; | ||
| tagColumnIndexMap = newTagColumnIndexMap; | ||
| idColumnIndexMap = newIdColumnIndexMap; |
Contributor
There was a problem hiding this comment.
There may still introduce inconsistency
Contributor
There was a problem hiding this comment.
And, may only retain tagColumnIndexMap since id is a deprecated name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR