KAFKA-14412: Use shared cache for Task offset sums #20954
+113
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reading Task state offsets for non-open Tasks from the `.checkpoint` file, we now maintain an in-memory cache of the latest changelog offsets for every Task on the instance. On start-up, this cache is seeded with the changelog offsets for every on-disk StateStore. Running Active and Standby Tasks then update this cache on every checkpoint to ensure it always reflects the offsets on-disk. This breaks the tight coupling between `TaskManager` and `.checkpoint` files, which will enable us to remove `.checkpoint` files in a later commit as part of KIP-1035.
Contributor
Author
|
@ableegoldman @mjsax @cadonna I had some time to pick this up, so I've rebased it against |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reading Task state offsets for non-open Tasks from the
.checkpointfile, we now maintain an in-memory cache of the latest changelog offsets for every Task on the instance.On start-up, this cache is seeded with the changelog offsets for every on-disk StateStore. Running Active and Standby Tasks then update this cache on every checkpoint to ensure it always reflects the offsets on-disk.
This breaks the tight coupling between
TaskManagerand.checkpointfiles, which will enable us to remove.checkpointfiles in a later commit as part of KIP-1035.