-
Notifications
You must be signed in to change notification settings - Fork 14.8k
MINOR: Address flaky wait for producer acks logging for checking when not al… #20957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…l members join group
|
|
||
| producer.start() | ||
| self.await_produced_messages(producer) | ||
| self.await_produced_messages(producer, timeout_sec=120) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've seen starting a producer can take longer than expected but it does start so increasing the timeout to reduce flakiness
lianetm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bbejeck !
|
@lianetm thanks for the review, I updated the PR |
|
@lianetm updated |
lianetm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
|
merged #20957 into trunk |
… not al… (#20957) Adding the following for some system tests - Increased timeout for `await_produced_messages` - Added more logging for `test_fencing_consumer` which has exhibited flakiness and is hard to reproduce Reviewers: Lianet Magrans<[email protected]>
|
cherry-picked to 4.1 |
… not al… (#20957) Adding the following for some system tests - Increased timeout for `await_produced_messages` - Added more logging for `test_fencing_consumer` which has exhibited flakiness and is hard to reproduce Reviewers: Lianet Magrans<[email protected]>
|
cherry-picked to 4.2 |
Adding the following for some system tests
await_produced_messagestest_fencing_consumerwhich has exhibitedflakiness and is hard to reproduce
Reviewers: Lianet Magrans[email protected]