Skip to content

Conversation

@bbejeck
Copy link
Member

@bbejeck bbejeck commented Nov 21, 2025

Adding the following for some system tests

  • Increased timeout for await_produced_messages
  • Added more logging for test_fencing_consumer which has exhibited
    flakiness and is hard to reproduce

Reviewers: Lianet Magrans[email protected]

@bbejeck bbejeck requested a review from lianetm November 21, 2025 21:52
@github-actions github-actions bot added tests Test fixes (including flaky tests) small Small PRs labels Nov 21, 2025

producer.start()
self.await_produced_messages(producer)
self.await_produced_messages(producer, timeout_sec=120)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've seen starting a producer can take longer than expected but it does start so increasing the timeout to reduce flakiness

Copy link
Member

@lianetm lianetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bbejeck !

@bbejeck
Copy link
Member Author

bbejeck commented Nov 24, 2025

@lianetm thanks for the review, I updated the PR

@bbejeck
Copy link
Member Author

bbejeck commented Nov 24, 2025

@lianetm updated

Copy link
Member

@lianetm lianetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@bbejeck bbejeck merged commit db336c3 into apache:trunk Nov 25, 2025
23 checks passed
@bbejeck
Copy link
Member Author

bbejeck commented Nov 25, 2025

merged #20957 into trunk

@bbejeck bbejeck deleted the MINOR_system_test_fixes branch November 25, 2025 20:23
bbejeck added a commit that referenced this pull request Nov 25, 2025
… not al… (#20957)

Adding the following for some system tests
- Increased timeout for `await_produced_messages`
- Added more logging for `test_fencing_consumer` which has exhibited
flakiness and is hard to reproduce

Reviewers: Lianet Magrans<[email protected]>
@bbejeck
Copy link
Member Author

bbejeck commented Nov 25, 2025

cherry-picked to 4.1

bbejeck added a commit that referenced this pull request Nov 25, 2025
… not al… (#20957)

Adding the following for some system tests
- Increased timeout for `await_produced_messages`
- Added more logging for `test_fencing_consumer` which has exhibited
flakiness and is hard to reproduce

Reviewers: Lianet Magrans<[email protected]>
@bbejeck
Copy link
Member Author

bbejeck commented Nov 25, 2025

cherry-picked to 4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants