MINOR: Bump LATEST_PRODUCTION to 4.2-IV1 in 4.2 branch #20972
Conversation
| public static MetadataVersion latestTesting() { | ||
| return VERSIONS[VERSIONS.length - 1]; | ||
| // There is no separate testing version because all features are currently stable. | ||
| return LATEST_PRODUCTION; |
There was a problem hiding this comment.
Perhasp we could add IBP_4_3_IV0 to align the code with other 4.x branches? This would also make the patch easier to cherry-pick to trunk
There was a problem hiding this comment.
Well, I did consider this, but there's no need for IBP_4_3_IV0 because there are no unstable features.
There was a problem hiding this comment.
This sounds like it ought to be part of the release process :)
There was a problem hiding this comment.
I've made a PR against trunk #20977. Let me know if you prefer that cherry-picked into 4.2.
There was a problem hiding this comment.
I prefer #20977 because it helps to avoid the awkward disabled tag 😃
There was a problem hiding this comment.
I'll fix the comments on that one then and will cherry-pick when it's ready.
AndrewJSchofield
changed the title
| V_4_2_0 = KafkaVersion("4.2.0") | ||
| LATEST_4_2 = V_4_2_0 | ||
| V_4_2_1 = KafkaVersion("4.2.1") | ||
| LATEST_4_2 = V_4_2_1 |
There was a problem hiding this comment.
I don't think we need this change yet? As a matter of fact, not even sure why the whole section for 4.2 already exists? We only add released versions here (and 4.2.0 is not release yet, and should only be added in trunk after 4.2.0 was release...) Sure, it doesn't hurt to add it, but it's dead code.
There was a problem hiding this comment.
This code was added by #20471 to prevent the use of new configurations in order kafka tools, we could remove the entire 4.2 section by reversing the version check condition. self >= V_4_2_0 -> self <= LATEST_4_1
There was a problem hiding this comment.
I see. Thanks for clarifying. Guess, for 4.2 branch we don't really use LATEST_4_2 anywhere else, so it might be fine. And the test code you refer to uses V_4_2_0 explicitly.
Bottom line: I understand why we needed to add V_4_2_0, but both LATEST_4_2 and V_4_2_1 seem not to be necessary for 4.2 branch, and especially pointing LATEST_4_2 to an unreleased version seems odd (even if it does not break anything as it's unused).
There was a problem hiding this comment.
I realise now that I was getting confused between Kafka versions and metadata versions.
|
Closed in favour of #20977. |
4 participants
Bump latest production metadata version for Apache Kafka 4.2.0 to enable
share groups and streams groups by default.