KNOX-3062 - Fix an issue where group headers were not added to POST and PUT requests #933
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@moresandeep - I think is still a valid issue to fix. Would you mind taking a review, update/rebase your change and submit a new patch? Thanks! |
Contributor
|
How are these changes specific to POST and PUT requests? |
Contributor
|
Looking closer again, I found this one irrelevant. The reason is, that the submitted code here assumes that #747 is merged, which isn't the case. |
Contributor
Author
|
I closed the JIRA a while ago and marked it as not an issue https://issues.apache.org/jira/browse/KNOX-3062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix an issue where group headers were not added to POST and PUT requests
How was this patch tested?
This patch was tested locally with POST and GET requests.