-
Notifications
You must be signed in to change notification settings - Fork 588
feat: support Topk data structure #3242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
PragmaTwice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for your contribution!
Before we move on to the PR review, could you please provide a more detailed explanation of your design? For example, for features like timeseries (#3044) and t-digest (#2542), there were corresponding proposals that helped the community better understand the data structure design and the reasoning behind it. This makes it easier for community members to review the work and reach a consensus.
Hi, thank you for the reminder and for this opportunity. |
|
@hidedim lot of thanks about your work. Could you check issue with conflict? |
|
This reverts commit 915580d.
support 5 Operation.
TOPK.RESERVE key args(k, width, depth, decay): create TopK data structure.
TOPK.INFO key: reply information of args(k, width, depth, decay).
TOPK.ADD key value: add values to topk.
TOPK.QUERY key value: reply is value existed in topk.
TOPK.LIST key: reply item of topk.