Skip to content

feat(ts): add the support of TS.ALTER command #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2025
Merged

feat(ts): add the support of TS.ALTER command #3264

merged 4 commits into from
Nov 21, 2025

Conversation

@var-nan
Copy link
Contributor

@var-nan var-nan commented Nov 17, 2025 •
edited by PragmaTwice
Loading

It closes #3214.

@PragmaTwice PragmaTwice changed the title feat(ts): add the support of TS.ALTER command (#3214) feat(ts): add the support of TS.ALTER command Nov 17, 2025
@PragmaTwice PragmaTwice requested a review from yezhizi November 17, 2025 15:25
PragmaTwice
PragmaTwice reviewed Nov 18, 2025
View reviewed changes
yezhizi
yezhizi reviewed Nov 18, 2025
View reviewed changes
yezhizi
yezhizi reviewed Nov 18, 2025
View reviewed changes
yezhizi
yezhizi reviewed Nov 18, 2025
View reviewed changes
yezhizi
yezhizi reviewed Nov 18, 2025
View reviewed changes
refactored TimeSeries::Alter(), enum TSAlterMode.
db5663b 
Only the disjoint labels are written to log when labels are updated.
@yezhizi
Copy link
Contributor

yezhizi commented Nov 20, 2025 

/home/runner/work/kvrocks/kvrocks/tests/cppunit/types/timeseries_test.cc:124:34: error: code should be clang-formatted [-Wclang-format-violations]
  EXPECT_TRUE(query_res.empty());

timeseries_test.cc not formarted. Could you fix it?

PragmaTwice
PragmaTwice reviewed Nov 20, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 21, 2025

Quality Gate Passed Quality Gate passed

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
62.4% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

@yezhizi yezhizi requested a review from PragmaTwice November 21, 2025 07:34
@PragmaTwice PragmaTwice merged commit 2dc7e9e into apache:unstable Nov 21, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@yezhizi yezhizi yezhizi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TimeSeries: Implement TS.ALTER command

3 participants

@var-nan @yezhizi @PragmaTwice