Skip to content

[MSHADE-124] keep original basedir after set d-r-p location to build dir#128

Open
gzm55 wants to merge 3 commits intoapache:masterfrom
gzm55:work/MSHADE-124
Open

[MSHADE-124] keep original basedir after set d-r-p location to build dir#128
gzm55 wants to merge 3 commits intoapache:masterfrom
gzm55:work/MSHADE-124

Conversation

@gzm55
Copy link

@gzm55 gzm55 commented Apr 5, 2022

From maven 3.2.5, the pom and basedir are seperated
(apache/maven@c15226f),
and add new api MavenProject::setPomFile() to only upodate pom location.

In this pr, the minimal maven version is bumped to 3.2.5, then use
setPomFile to only update pom file location, leaving ${basedir}
unchanged.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

From maven 3.2.5, the pom and basedir are seperated
(apache/maven@c15226f),
and add new api `MavenProject::setPomFile()` to only upodate pom location.

In this pr, the minimal maven version is bumped to 3.2.5, then use
`setPomFile` to only update pom file location, leaving `${basedir}`
unchanged.
@jira-importer
Copy link

Resolve #496

1 similar comment
@jira-importer
Copy link

Resolve #496

@altaiezior
Copy link

@cstamas I wanted to refer my previous comment for this MR, I wanted to change the base location of dependency reduced pom. Can we check this MR and resolves issues if any.

So my use-case here for this fix is to move the dependency-reduced-pom.xml to the target folder, the reason for this that I don't want my search results to include the values from this file.

Target folder is excluded by default in IntelliJ and hence this helps

@altaiezior
Copy link

@rmannibucau we can just add project.setOriginalModel(model); in this MR after project.setPomFile(dependencyReducedPomLocation); and it should be ready as well and work with maven4

@altaiezior
Copy link

@cstamas would it be possible to take this up?

@cstamas
Copy link
Member

cstamas commented Mar 16, 2026

@gzm55 care to rebase? Thanks!

@altaiezior
Copy link

Yes I can but I think I will have to create the MR again, since it is from a fork right? So the history would be lost?

@gzm55
Copy link
Author

gzm55 commented Mar 17, 2026

@gzm55 care to rebase? Thanks!

pr is rebased.

@altaiezior
Copy link

@cstamas can we check this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants