[#11486] replace '@' with pipe in sed #11499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
approved these changes
Nov 30, 2025
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Dec 2, 2025
This commit unifies the .mvn/jvm.config parsing approach by using
JvmConfigParser.java on both Unix and Windows platforms, solving
multiple related issues with special character handling.
Issues Fixed:
- MNG-11363: Pipe symbols (|) in jvm.config cause shell parsing errors
- MNG-11485: Non-POSIX xargs -0 fails on AIX, FreeBSD, and other systems
- MNG-11486: sed command fails when paths contain @ symbols
Changes:
- Modified mvn (Unix): Replaced awk/sed pipeline with JvmConfigParser.java
compilation and execution. This ensures POSIX compliance and handles
all special characters (pipes, quotes, @, etc.) correctly.
- Modified mvn.cmd (Windows): Removed debug output and updated comments
to reflect all special characters now handled correctly.
- Added integration test MavenITgh11485AtSignInJvmConfigTest to verify
@ symbol handling in jvm.config files (important for Jenkins workspaces
like workspace/project_PR-350@2).
The Java-based parser approach:
- Handles comment removal (both # at start and end-of-line)
- Performs variable substitution (${MAVEN_PROJECTBASEDIR})
- Correctly parses quoted arguments with special characters
- Works consistently across all platforms
- Is POSIX-compliant (no xargs -0, awk, or complex sed needed)
Performance Impact:
Unix script is ~200ms slower (320ms → 520ms for mvn -v) due to Java
compilation, but this is acceptable for the correctness, maintainability,
and cross-platform consistency benefits.
Related PRs:
- Fixes apache#11365 (MNG-11363: pipe symbols)
- Fixes apache#11489 (MNG-11485: POSIX compliance)
- Fixes apache#11499 (MNG-11486: @ symbols in paths)
Contributor
|
This PR has been superseded by #11365, which now fixes all three related issues:
The unified solution uses Integration tests for @ symbol handling have been added to #11365. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@with|as separator, worked well before, fixes sed: -e expression #1, char 125: unknown option to `s' #11486${}instead of plain$