ostest: add kconfig to set priority #3330
Open
+99
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
previously approved these changes
Jan 14, 2026
Contributor
|
@zzby0 please fix: |
cederom
reviewed
Jan 14, 2026
testing/ostest/mqueue.c
Outdated
| } | ||
|
|
||
| sparam.sched_priority = (prio_min + prio_mid) / 2; | ||
| sparam.sched_priority = PRIORITY - 10; |
Contributor
There was a problem hiding this comment.
what if someone sets priority <= 10 for any reason? shouldn't we have a check here?
Author
There was a problem hiding this comment.
thanks for review :) i have added check here
zzby0
force-pushed
the
ostest
branch
2 times, most recently
from
e9e4b71 to
f219ca2
Compare
ostest may fail because some other task with higher priority are running, this change we use ostest priority for testcases, so that we can easily set testcase priority. Signed-off-by: yangao1 <[email protected]>
ostest sometimes fail because other threads with higher priority are running, we add ostest priority kconfig, so that we can increase ostest priority easier. Signed-off-by: yangao1 <[email protected]>
fix spelling error reported by codespellrc. Signed-off-by: guanyi3 <[email protected]>
zzby0
force-pushed
the
ostest
branch
2 times, most recently
from
bf3f1db to
ff81d41
Compare
Because the priority of ostest was increased, the priority of the main thread also increased. Newly created threads still used the default priority, causing the parent thread to prematurely cancel the child thread. This resulted in the child thread not being properly garbage collected, leading to a system busy loop. Signed-off-by: yangao1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
sometimes ostest fail because of other task with higher priority are running, this PR add kconfig to set ostest priority so that we can increase ostest priority easily.
Impact
ostest priority
Testing
ostest