sched/signals: improvements for when all signals are disabled #17991

wangchdo · 2026-01-18T14:23:05Z

Summary

THis PR includes below three updates:

updatesleep()and usleep() to use nxsched_nanosleep() when all signals are disabled, so when all signals are disabled, sleep function can still be available and ostest can pass
remove pthread_kill() and pthread_sigmask() implementations when all signals are disabled, since these two functions rely on signals
remove the altmdm_timer related implementation and API definitions when all signals are disabled, since they rely on signals

Impact

Improve the implementation when all signals are disabled, only impact the functions when all signals are disabled.

Testing

ostest for when all signals are disabled depends on apache/nuttx-apps#3333

ostest passed on rv-virt:smp64

NuttShell (NSH)
nsh> 
nsh> 
nsh> uname -a 
NuttX 0.0.0 13e8f81f01-dirty Jan 18 2026 22:15:53 risc-v rv-virt
nsh> ostest

(...)

user_main: smp call test
smp_call_test: Test start
smp_call_test: Call cpu 0, nowait
smp_call_test: Call cpu 0, wait
smp_call_test: Call cpu 1, nowait
smp_call_test: Call cpu 1, wait
smp_call_test: Call cpu 2, nowait
smp_call_test: Call cpu 2, wait
smp_call_test: Call cpu 3, nowait
smp_call_test: Call cpu 3, wait
smp_call_test: Call cpu 4, nowait
smp_call_test: Call cpu 4, wait
smp_call_test: Call cpu 5, nowait
smp_call_test: Call cpu 5, wait
smp_call_test: Call cpu 6, nowait
smp_call_test: Call cpu 6, wait
smp_call_test: Call cpu 7, nowait
smp_call_test: Call cpu 7, wait
smp_call_test: Call multi cpu, nowait
smp_call_test: Call in interrupt, wait
smp_call_test: Call multi cpu, wait
smp_call_test: Test success

Final memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     1fc3780  1fc3780
ordblks         1        6
mxordblk  1fb86d8  1fa2b78
uordblks     b0a8    11f20
fordblks  1fb86d8  1fb1860
user_main: Exiting
ostest_main: Exiting with status 0
nsh>

drivers/input/button_upper.c

When all signals are disabled, remove the altmdm_timer-related implementation and API definitions. Signed-off-by: Chengdong Wang <[email protected]>

drivers/input/ajoystick.c

When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <[email protected]>

DEV_GPIO_NSIGNALS relies on signal support. Add an explicit Kconfig dependency on SIGNALS to prevent invalid no-signal configurations. Signed-off-by: Chengdong Wang <[email protected]>

When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <[email protected]>

When all signals are disabled, remove pthread_kill and pthread_sigmask implementations. Signed-off-by: Chengdong Wang <[email protected]>

update sleep and usleep to use nxsched_nanosleep wihen all signals are disabled Signed-off-by: Chengdong Wang <[email protected]>

When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <[email protected]>

…abled When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <[email protected]>

…bled When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <[email protected]>

When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <[email protected]>

… disabled When all signals are disabled, nxsig_notification is not available and should not be invoked. Remove the call to avoid build and runtime issues in no-signal configurations. Signed-off-by: Chengdong Wang <[email protected]>

xiaoxiang781216 · 2026-01-19T04:02:15Z

drivers/input/button_upper.c

      /* Have any signal events occurred? */

+#ifndef CONFIG_DISABLE_ALL_SIGNALS
      if ((press & opriv->bo_notify.bn_press)     != 0 ||


nee d remove from btn_open_s

xiaoxiang781216 · 2026-01-19T04:02:43Z

drivers/input/djoystick.c

      /* Have any signal events occurred? */

+#ifndef CONFIG_DISABLE_ALL_SIGNALS
      if ((press & opriv->do_notify.dn_press)     != 0 ||


need remove from djoy_open_s

xiaoxiang781216 · 2026-01-19T04:05:15Z

drivers/lcd/ft80x.c


      /* Yes.. Signal the client */

      info->event.sigev_value.sival_int = value;


need guard event in ft80x_dev_s

xiaoxiang781216 · 2026-01-19T04:09:20Z

wireless/ieee802154/mac802154_netdev.c

+#ifndef CONFIG_DISABLE_ALL_SIGNALS
      if (priv->md_notify_registered)
        {
          priv->md_notify_event.sigev_value.sival_int = primitive->type;


guard md_notify_event in mac802154_chardevice_s

xiaoxiang781216 · 2026-01-19T04:10:58Z

libs/libc/aio/lio_listio.c

      else
        {
          status = nxsig_notification(_SCHED_GETPID(), sig,
                                      SI_ASYNCIO, &aiocbp->aio_sigwork);


guard in aiocb

xiaoxiang781216 · 2026-01-19T04:12:09Z

libs/libc/aio/lio_listio.c

 *
 ****************************************************************************/

 static int lio_sigsetup(FAR struct aiocb * const *list, int nent,


does aio still work without signal? if not, we should diasable all aio functionality.

xiaoxiang781216 · 2026-01-19T05:13:57Z

fs/mount/fs_automount.c

            {
              /* Save the notification events */

              opriv->ao_notify.an_mount  = notify->an_mount;


does automount functionality still work

xiaoxiang781216 · 2026-01-19T05:14:52Z

drivers/wireless/ieee802154/xbee/xbee_netdev.c

+#ifndef CONFIG_DISABLE_ALL_SIGNALS
      if (priv->xd_notify_registered)
        {
          priv->xd_notify_event.sigev_value.sival_int = primitive->type;


guard in xbeenet_driver_s too

wangchdo requested review from GUIDINGLI, gustavonihei, jerpelea, raiden00pl, simbit18 and xiaoxiang781216 as code owners January 18, 2026 14:23

github-actions bot added Area: Drivers Drivers issues Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Jan 18, 2026

wangchdo force-pushed the fix_disable_all_signals_issue branch 2 times, most recently from c53b84a to 6b46448 Compare January 18, 2026 15:17

xiaoxiang781216 previously approved these changes Jan 18, 2026

View reviewed changes

drivers/input/button_upper.c Show resolved Hide resolved

drivers/alt1250: remove altmdm_timer for no signals

f258528

When all signals are disabled, remove the altmdm_timer-related implementation and API definitions. Signed-off-by: Chengdong Wang <[email protected]>

wangchdo dismissed xiaoxiang781216’s stale review via a1c1f12 January 19, 2026 02:36

wangchdo force-pushed the fix_disable_all_signals_issue branch from 6b46448 to a1c1f12 Compare January 19, 2026 02:36

wangchdo requested review from acassis, antmerlino, michallenc, pkarashchenko and yamt as code owners January 19, 2026 02:36

github-actions bot added Area: Networking Effects networking subsystem Area: File System File System issues Area: Sensors Sensors issues Area: Graphics Size: M The size of the change in this PR is medium labels Jan 19, 2026

wangchdo requested a review from xiaoxiang781216 January 19, 2026 02:38

xiaoxiang781216 reviewed Jan 19, 2026

View reviewed changes

drivers/input/ajoystick.c Show resolved Hide resolved

wangchdo added 3 commits January 19, 2026 10:50

drivers/ioexpander: add DEV_GPIO_NSIGNALS dependency on signals

12f5a74

DEV_GPIO_NSIGNALS relies on signal support. Add an explicit Kconfig dependency on SIGNALS to prevent invalid no-signal configurations. Signed-off-by: Chengdong Wang <[email protected]>

wangchdo added 8 commits January 19, 2026 10:56

pthread: remove pthread_kill and pthread_sigmask for no signals

6d22c54

When all signals are disabled, remove pthread_kill and pthread_sigmask implementations. Signed-off-by: Chengdong Wang <[email protected]>

libs/libc: update sleep and usleep for no signals

63cd5c0

update sleep and usleep to use nxsched_nanosleep wihen all signals are disabled Signed-off-by: Chengdong Wang <[email protected]>

wangchdo force-pushed the fix_disable_all_signals_issue branch from a1c1f12 to fb52bef Compare January 19, 2026 03:05

wangchdo force-pushed the fix_disable_all_signals_issue branch from fb52bef to 286d12b Compare January 19, 2026 03:07

wangchdo requested a review from xiaoxiang781216 January 19, 2026 03:16

xiaoxiang781216 reviewed Jan 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

sched/signals: improvements for when all signals are disabled #17991

sched/signals: improvements for when all signals are disabled #17991

wangchdo commented Jan 18, 2026

Uh oh!

Uh oh!

Uh oh!

xiaoxiang781216 Jan 19, 2026

Uh oh!

xiaoxiang781216 Jan 19, 2026

Uh oh!

xiaoxiang781216 Jan 19, 2026

Uh oh!

xiaoxiang781216 Jan 19, 2026

Uh oh!

xiaoxiang781216 Jan 19, 2026

Uh oh!

xiaoxiang781216 Jan 19, 2026

Uh oh!

xiaoxiang781216 Jan 19, 2026

Uh oh!

xiaoxiang781216 Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		/* Yes.. Signal the client */

		info->event.sigev_value.sival_int = value;

sched/signals: improvements for when all signals are disabled #17991

Are you sure you want to change the base?

sched/signals: improvements for when all signals are disabled #17991

Conversation

wangchdo commented Jan 18, 2026

Summary

Impact

Testing

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants