feat(aws): support trusted S3 Express CreateSession endpoints - #843
Draft
Xuanwo wants to merge 2 commits into
Draft
feat(aws): support trusted S3 Express CreateSession endpoints#843Xuanwo wants to merge 2 commits into
Xuanwo wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
S3 Express
CreateSessionconfiguration only accepted AWS directory-bucket names and derived AWS or AWS China Zonal endpoints. That excluded S3-compatible deployments which exposeCreateSessionat a deployment-owned origin. A concrete documented example is MinIO AIStor S3 Express mode, whose S3 API compatibility reference listsCreateSession.This introduces a separate, fallible trusted-endpoint configuration that binds the compatible bucket, SigV4 Region, and HTTPS origin before source credentials can be loaded. It preserves the strict AWS constructor and exposes no synthetic Zone or partition. The trust boundary is explicit: the configured origin receives the AWS
Authorizationheader and any sourcex-amz-security-token.Live AWS and MinIO AIStor interoperability were not run because this checkout has no authorized endpoint or credential environment. Deterministic tests cover pre-I/O endpoint validation, exact request routing and signing for long-lived and temporary source credentials, maximum-allowed mode behavior, and redaction.
Fixes #838