Repository navigation
Let valueEquals match a copy() against its original - #130
Merged
Merged
Conversation
complex_values_equal walks both trees until their content runs out. A value made by copy() is rooted at a document, so its walk ends on ENDDOC, while an element in a document ends on END. The two tokens differ, so x.copy().valueEquals(x) was false for every complex value. Treat either finish token as the end of the content. Found by POI's TestXWPFNumbering.testCompareAbstractNum, which matches a copied CTAbstractNum against the numbering's own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #106 (XMLBEANS-658).
XmlValueComparison.content_equalwalks both trees until their content runs out. A value made bycopy()is rooted at a document, so its walk ends onENDDOC. An element inside a document ends onEND. Because the two tokens differ,x.copy().valueEquals(x)returned false for every complex value.The fix treats either finish token as the end of the content.
POI's
TestXWPFNumbering.testCompareAbstractNumfailed on 5.5.0-SNAPSHOT because of this:XWPFNumbering.getIdOfAbstractNumcompares a copiedCTAbstractNumagainst the numbering's own.ValueEqualsTest.testCopyEqualsOriginalfails without the fix and passes with it./gradlew testpasses🤖 Generated with Claude Code