refactor: move shared computing unit types and services#4358
Open
gracecluvohio wants to merge 6 commits intoapache:mainfrom
Open
refactor: move shared computing unit types and services#4358gracecluvohio wants to merge 6 commits intoapache:mainfrom
gracecluvohio wants to merge 6 commits intoapache:mainfrom
Conversation
Contributor
|
@gracecluvohio Please fix the failed test cases. |
kunwp1
approved these changes
Apr 11, 2026
Contributor
There was a problem hiding this comment.
| .../workspace/service/workflow-computing-unit | .../common/service/computing-unit/computing-unit-managing |
|---|
Is there a reason you changed the folder name from workflow-computing-unit to computing-unit-managing?
Contributor
Author
There was a problem hiding this comment.
Just because it's no longer just for workflow, it's also for dashboard. Should I change the name of the file and the component as well?
Contributor
There was a problem hiding this comment.
Let's wait for @bobbai00's input as he is familiar with these codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
(For readability,
...refers tofrontend/src/appin the codebase.)This PR moves shared computing unit types and services to
.../commonunderfrontend/src/app. Specifically:.../dashboard/service/user/computing-unit-actions.../common/service/computing-unit/computing-unit-actions.../workspace/service/workflow-computing-unit.../common/service/computing-unit/computing-unit-managing.../workspace/service/computing-unit-status.../common/service/computing-unit/computing-unit-status.../workspace/types/computing-unit-connection.interface.ts.../common/type/computing-unit-connection.interface.ts.../workspace/types/workflow-computing-unit.ts.../common/type/workflow-computing-unit.tsAny related issues, documentation, discussions?
Closes #4362
How was this PR tested?
Locally tested
Was this PR authored or co-authored using generative AI tooling?
No