Skip to content

feat: enable text selection by default across the platform#4366

Merged
mengw15 merged 4 commits intoapache:mainfrom
xuang7:feat/dataset-page-text-selection
Apr 11, 2026
Merged

feat: enable text selection by default across the platform#4366
mengw15 merged 4 commits intoapache:mainfrom
xuang7:feat/dataset-page-text-selection

Conversation

@xuang7
Copy link
Copy Markdown
Contributor

@xuang7 xuang7 commented Apr 11, 2026

What changes were proposed in this PR?

This PR enables text selection by default across the platform. The changes include:

  1. Remove the global non-selectable rule and restrict non-selectable behavior to the following global selectors: .ant-menu-item, .ant-menu-submenu-title, img

  2. Restore component-level user-select: none declarations removed in #3898:

  • #left-container in left-panel.component.scss
  • #right-container in property-editor.component.scss
  • #result-container in result-panel.component.scss
  • texera-mini-map in workspace.component.scss
  1. Layers dropdown: add a rule to prevent text selection in the layers dropdown overlay introduced in PR 3898.

Demonstration:
Dataset page:
dataset

dataset-page

workflow:
workflow

Any related issues, documentation, discussions?

Closes #4365

How was this PR tested?

Manually verified

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude sonnet 4.6

@github-actions github-actions bot added feature frontend Changes related to the frontend GUI labels Apr 11, 2026
@chenlica chenlica requested a review from mengw15 April 11, 2026 03:19
@chenlica
Copy link
Copy Markdown
Contributor

@mengw15 Please review it, possibly your first PR to review as a committer :-)

Copy link
Copy Markdown
Contributor

@mengw15 mengw15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question in the related issue. Maybe other people can give inputs as well

@xuang7 xuang7 requested a review from mengw15 April 11, 2026 20:39
@xuang7 xuang7 changed the title feat: enable text selection on dataset page metadata feat: enable text selection by default across the platform Apr 11, 2026
Copy link
Copy Markdown
Contributor

@mengw15 mengw15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mengw15 mengw15 enabled auto-merge (squash) April 11, 2026 21:00
@mengw15 mengw15 merged commit 786f7d7 into apache:main Apr 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable text selection on specific metadata on dataset page

3 participants