Skip to content

TEZ-4728: Replace deprecated use of Guava Charsets.UTF_8 with StandardCharsets.UTF_8#511

Open
Aggarwal-Raghav wants to merge 2 commits into
apache:masterfrom
Aggarwal-Raghav:TEZ-4728
Open

TEZ-4728: Replace deprecated use of Guava Charsets.UTF_8 with StandardCharsets.UTF_8#511
Aggarwal-Raghav wants to merge 2 commits into
apache:masterfrom
Aggarwal-Raghav:TEZ-4728

Conversation

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for branch
+1 💚 mvninstall 4m 49s master passed
+1 💚 compile 3m 58s master passed
+1 💚 checkstyle 2m 19s master passed
+1 💚 javadoc 2m 33s master passed
+0 🆗 spotbugs 1m 25s tez-api in master has 92 extant spotbugs warnings.
+0 🆗 spotbugs 0m 53s tez-runtime-internals in master has 92 extant spotbugs warnings.
+0 🆗 spotbugs 1m 12s tez-runtime-library in master has 143 extant spotbugs warnings.
+0 🆗 spotbugs 0m 44s tez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 codespell 1m 45s No new issues.
+1 💚 compile 3m 56s the patch passed
+1 💚 javac 3m 56s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 28s /results-checkstyle-tez-api.txt tez-api: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 32s /results-checkstyle-tez-runtime-library.txt tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
-0 ⚠️ checkstyle 0m 24s /results-checkstyle-tez-ext-service-tests.txt tez-ext-service-tests: The patch generated 1 new + 42 unchanged - 1 fixed = 43 total (was 43)
-0 ⚠️ checkstyle 0m 25s /results-checkstyle-tez-plugins_tez-aux-services.txt tez-plugins/tez-aux-services: The patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53)
+1 💚 javadoc 2m 32s the patch passed
+1 💚 spotbugs 6m 4s the patch passed
_ Other Tests _
-1 ❌ unit 78m 24s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 2m 2s The patch does not generate ASF License warnings.
124m 1s
Reason Tests
Failed junit tests tez.dag.api.client.TestDAGClientServer
tez.dag.app.TestMockDAGAppMaster
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/1/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets
uname Linux 32ee5d7c8e0f 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13 18:41:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / 5766cda
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/1/testReport/
Max. process+thread count 1448 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-runtime-library tez-ext-service-tests tez-plugins/tez-aux-services U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/1/console
versions git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for branch
+1 💚 mvninstall 2m 52s master passed
+1 💚 compile 2m 36s master passed
+1 💚 checkstyle 1m 38s master passed
+1 💚 javadoc 1m 51s master passed
+0 🆗 spotbugs 0m 53s tez-api in master has 92 extant spotbugs warnings.
+0 🆗 spotbugs 0m 33s tez-runtime-internals in master has 92 extant spotbugs warnings.
+0 🆗 spotbugs 0m 46s tez-runtime-library in master has 143 extant spotbugs warnings.
+0 🆗 spotbugs 0m 31s tez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
+1 💚 mvninstall 2m 18s the patch passed
+1 💚 codespell 0m 48s No new issues.
+1 💚 compile 2m 34s the patch passed
+1 💚 javac 2m 34s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 19s /results-checkstyle-tez-api.txt tez-api: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 22s /results-checkstyle-tez-runtime-library.txt tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
-0 ⚠️ checkstyle 0m 17s /results-checkstyle-tez-ext-service-tests.txt tez-ext-service-tests: The patch generated 1 new + 42 unchanged - 1 fixed = 43 total (was 43)
-0 ⚠️ checkstyle 0m 17s /results-checkstyle-tez-plugins_tez-aux-services.txt tez-plugins/tez-aux-services: The patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53)
+1 💚 javadoc 1m 50s the patch passed
+1 💚 spotbugs 3m 49s the patch passed
_ Other Tests _
+1 💚 unit 60m 59s root in the patch passed.
+1 💚 asflicense 1m 39s The patch does not generate ASF License warnings.
92m 50s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/2/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets
uname Linux 51cd086d9c89 5.15.0-179-generic #189-Ubuntu SMP Tue May 5 18:20:56 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / 5766cda
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/2/testReport/
Max. process+thread count 1372 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-runtime-library tez-ext-service-tests tez-plugins/tez-aux-services U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/2/console
versions git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
Contributor

the patch introduced some checkstyle warnings, please fix them, otherwise, looks good to me overall 🚀

@abstractdog abstractdog self-requested a review June 18, 2026 06:13

@abstractdog abstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for branch
+1 💚 mvninstall 2m 51s master passed
+1 💚 compile 2m 36s master passed
+1 💚 checkstyle 1m 36s master passed
+1 💚 javadoc 1m 50s master passed
+0 🆗 spotbugs 0m 51s tez-api in master has 92 extant spotbugs warnings.
+0 🆗 spotbugs 0m 34s tez-runtime-internals in master has 92 extant spotbugs warnings.
+0 🆗 spotbugs 0m 47s tez-runtime-library in master has 143 extant spotbugs warnings.
+0 🆗 spotbugs 0m 28s tez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
+1 💚 mvninstall 2m 11s the patch passed
+1 💚 codespell 0m 48s No new issues.
+1 💚 compile 2m 35s the patch passed
+1 💚 javac 2m 35s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 19s The patch passed checkstyle in tez-api
+1 💚 checkstyle 0m 18s The patch passed checkstyle in tez-runtime-internals
+1 💚 checkstyle 0m 21s The patch passed checkstyle in tez-runtime-library
+1 💚 checkstyle 0m 14s tez-ext-service-tests: The patch generated 0 new + 42 unchanged - 1 fixed = 42 total (was 43)
+1 💚 checkstyle 0m 18s tez-plugins/tez-aux-services: The patch generated 0 new + 52 unchanged - 1 fixed = 52 total (was 53)
+1 💚 javadoc 1m 40s the patch passed
+1 💚 spotbugs 3m 57s the patch passed
_ Other Tests _
+1 💚 unit 61m 11s root in the patch passed.
+1 💚 asflicense 1m 40s The patch does not generate ASF License warnings.
90m 28s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/3/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets
uname Linux b58a0a57af4a 5.15.0-179-generic #189-Ubuntu SMP Tue May 5 18:20:56 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / 5766cda
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/3/testReport/
Max. process+thread count 1361 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-runtime-library tez-ext-service-tests tez-plugins/tez-aux-services U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/3/console
versions git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@maheshrajus

Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants