THRIFT-5885: Python incorrectly deserializes Enum #3232
+99
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJCombrink
force-pushed
the
THRIFT-5885_fix_enum_generate
branch
4 times, most recently
from
a886f19 to
c7e1917
Compare
CJCombrink
force-pushed
the
THRIFT-5885_fix_enum_generate
branch
from
c7e1917 to
53e4ea1
Compare
CJCombrink
force-pushed
the
THRIFT-5885_fix_enum_generate
branch
from
53e4ea1 to
9f52603
Compare
Contributor
Author
|
This branch is staggered on top of the changes in #3232 |
CJCombrink
force-pushed
the
THRIFT-5885_fix_enum_generate
branch
from
9f52603 to
e1e3885
Compare
- find_package(PythonInterp) and find_package(PythonLibs) were deprecated in 3.12 and removed in 3.27 - The project minimum is at 3.16 already
- Deprecated in Python 3.2 and removed in 3.11
- collections.abc was added in 3.3 collections.Hashable removed in 3.10
- Locally and in Windows actions the second option is needed
- Full UUID support not added and this seems to work for some cases but not all, thus removing until full UUID is added
- And add message if interpreter not found - Remove the QUIET to get some idea of what cmake is doing - Trying to debug issue on Appveyor
- The change in find_package favours the latest Python - Force cmake to use the one specified - Put back the echo again since it is needed
- Same as per the cmake side
- No need for the check in the step any more since not supporting python 2
- Common problem, common code
- assert_ was removed in Python 3 and later removed - Fixed the script to error out correctly when the tests fail - The RunClientServer.py test did not fail as expected on this error
- Also an issue for latest builds on later windows not only the appveyor builds like originally thoughts - Used the code as suggested from the ticket as-is without too much understanding
CJCombrink
force-pushed
the
THRIFT-5885_fix_enum_generate
branch
from
e1e3885 to
d168ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix issue with enum deserialion
Disclaimer: I am seeing the same issue for recent Windows builds and this change as suggested in the ticket solves the issue.
I am not sure however if this is correct since this is a part of Python that I am not experienced with
[skip ci]anywhere in the commit message to free up build resources.