Skip to content
This repository was archived by the owner on Jun 7, 2021. It is now read-only.

Conversation

@wenjun-zhu
Copy link
Contributor

Two points:

  • append a letter x to the function name setDiagsArea()
  • add a new function shareDiagsArea(), which increase the refCount of the source ComDiagsArea.

This PR serves as a code base for further discussion. And the appendix letter x would be removed before merging.

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3006/

@Traf-Jenkins
Copy link

Can one of the admins verify this patch?

2 similar comments
@Traf-Jenkins
Copy link

Can one of the admins verify this patch?

@Traf-Jenkins
Copy link

Can one of the admins verify this patch?

@Traf-Jenkins
Copy link

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3007/

@Traf-Jenkins
Copy link

@DaveBirdsall
Copy link
Contributor

Looks like compGeneral/TEST006 might be coring.

Might want to run full regressions on a workstation for this change.

@sandhyasun
Copy link
Contributor

I don't see any comments in the JIRA on the change description. So trying to summarize here with a question .... Is the change to simply change all places (in ex)queu class and ExAtp class) where we do a setDiagsArea(da) followed by da->incrRefCount() to be done with one descriptive method - shareDiagsArea(da) ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants