Improve diagnostic messages in JdbcExecutor when resolving execution tasks#714
Open
mohit-devlogs wants to merge 2 commits intoapache:mainfrom
Open
Improve diagnostic messages in JdbcExecutor when resolving execution tasks#714mohit-devlogs wants to merge 2 commits intoapache:mainfrom
mohit-devlogs wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
|
Hi @mohit-devlogs we will take a look at your PR but until then I am wondering why you have removed the comments the code had. |
Contributor
Author
Thank you for pointing this out. As for the comments, these were not supposed to be removed. When I modified the code to enhance the diagnostic information, it appears that I inadvertently modified the code block, resulting in the removal of the comments. I will restore the original comments and update the PR so that it only contains the intended diagnostic improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the method
findJdbcExecutionOperatorTaskInStagerelies on the use of assertions andWayangCollections.getSinglefor the acquisition of the consumer of the output channel.When the assumptions are not met, the error messages given, such as "[] is not a singleton", are not very clear and do not assist very much for debugging purposes.
In the current code, the assumptions have been replaced with validations and
WayangException.