Fix tuple type support in typecheck() and flatmap inference (fixes #632)#715
Open
Zeyad-Hassan-1 wants to merge 1 commit intoapache:mainfrom
Open
Fix tuple type support in typecheck() and flatmap inference (fixes #632)#715Zeyad-Hassan-1 wants to merge 1 commit intoapache:mainfrom
Zeyad-Hassan-1 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #632
What was broken:
Tuple Type Validation:
typecheck()intypes.pywas not handling tuple types correctly. When a user passes(str, int)as a type,get_origin()returnsNone, so the existingisinstance(input_type, Tuple)check never matched.isinstance(input_type, tuple)with recursion to support nested types like(typing.Tuple[str, int], typing.Tuple[str, int]).Python 3.12+ Compatibility:
get_type_flatmap_function()usedtype(sig.return_annotation) != type(Iterable), which breaks in Python 3.12+ becauseIterableandIterable[str]are represented as different internal classes.get_origin(sig.return_annotation) is not collections.abc.Iterablefor more robust validation across Python versions.Verification:
The previously skipped
test_wordcountnow passes end-to-end, integrated with the Java JSON server.