Refactor benchmark jobs and remove hardcoded paths (Fixes #418)#718
Open
makarandhinge wants to merge 5 commits intoapache:mainfrom
Open
Refactor benchmark jobs and remove hardcoded paths (Fixes #418)#718makarandhinge wants to merge 5 commits intoapache:mainfrom
makarandhinge wants to merge 5 commits intoapache:mainfrom
Conversation
- Replace hardcoded input path with configurable argument - Replace hardcoded output path 'lala.out' with configurable argument - Add default output path as <input-file>.out if not specified - Add usage message and argument validation - Addresses issue apache#418
Contributor
|
Thanks @makarandhinge. It would be better if we keep the JavaNativeAPI examples and add the respective ones with the planbuilder instead of replacing them. |
Contributor
Author
|
Thank you for the suggestion @zkaoudi. I will restore the original JavaNativeAPI examples and add separate implementations using JavaPlanBuilder instead of replacing them. This way both approaches will remain available in the benchmark module. I will update the PR accordingly. |
fdc7ca9 to
bf7a708
Compare
Contributor
Author
|
Hi @zkaoudi, I have updated the PR accordingly. The original JavaNativeAPI examples are now preserved, and separate implementations using Please let me know if any further adjustments are needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR revisits and cleans up benchmark jobs in the
wayang-benchmarkmodule as requested in issue #418.Based on maintainer feedback, the original JavaNativeAPI examples were preserved and equivalent implementations using
JavaPlanBuilderwere added instead of replacing them. This keeps both APIs available for benchmarking and comparison.Changes Made
Benchmark Improvements
Grep.java.Added JavaPlanBuilder Implementations
TPCHQ1WithPlanBuilder.javaas a JavaPlanBuilder version ofTPCHQ1WithJavaNative.java.WordCountWithPlanBuilder.javaas a JavaPlanBuilder version ofWordCountWithJavaNativeAPI.java.Code Cleanup
Main.javaby removing unused imports and addingConfiguration.WordCountParquet.javaby removing unused imports and addingConfiguration.WordCount.javaby removing commented code.Current Benchmark Structure
Testing
Related Issue
Fixes #418