Fix test resources and List type handling in test_dl_tensorflow#728
Open
Harshakamalur wants to merge 1 commit intoapache:mainfrom
Open
Fix test resources and List type handling in test_dl_tensorflow#728Harshakamalur wants to merge 1 commit intoapache:mainfrom
Harshakamalur wants to merge 1 commit intoapache:mainfrom
Conversation
Author
|
Hi @apache/wayang-committers, I've submitted this PR to fix #630. Could you please assign this to me and approve the workflows so the CI can run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #630
This PR fixes the previously skipped
test_dl_tensorflowtest by addressing both issues mentioned in the issue: missing test resources and type errors with nested lists.Changes
python/src/pywy/tests/test_dl.py@pytest.mark.skipdecorator/var/www/html/paths withimportlib.resourcespointing to proper bundled test resourcesfloats: List[List[int]]→List[List[float]]python/src/pywy/types.pytypecheck()to useget_origin()instead ofisinstance()for correct handling of nested generic types likeList[List[float]]isinstance(input_type, List)does not work for typing generics;get_origin(input_type) is listis the correct approachTest Result
The test now runs and successfully constructs the full computation plan. The
ConnectionErrorat the end is expected behavior, executing the plan requires a running Wayang backend server, which is outside the scope of this fix.Future Improvements
ConnectionErrorat execution time could be addressed in a follow-up by mocking the backend connection or adding a@pytest.mark.integrationmarker to separate unit and integration tests.Related
Closes #630