Update versions in requirements.txt and remove deprecated feature#61
Open
tofu-rocketry wants to merge 6 commits intodevfrom
Open
Update versions in requirements.txt and remove deprecated feature#61tofu-rocketry wants to merge 6 commits intodevfrom
tofu-rocketry wants to merge 6 commits intodevfrom
Conversation
Member
|
related issue #57 |
Member
Author
|
I couldn't figure out why the unit tests are failing. |
Member
|
I believe the immediate issue is that in between Django 1.6 and 1.11, |
Member
Author
|
Ah, here's the release notes on that: https://docs.djangoproject.com/en/2.2/releases/1.8/#django-conf-urls-patterns |
Member
Author
|
They've also deprecated the |
Member
Author
|
The pagination looks fiddly to fix, so I'm stopping here for the moment. Good news is that the Python 3 build is now failing on the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Django and rest framework versions in
requirements.txtas current versions listed have security vulnerabilities. Also remotepatterns()as that is deprecated in this later version.