Enhance exception message for non-object relation

[rvanlaak]

Did receive this exception in an environment out of my control, and message was not helping sufficiently with root cause analysis.

Q	A
Branch?	main
Tickets	N/A
License	MIT
Doc PR	N/A

[soyuka]

isn't this exposing too much information?

[rvanlaak]

By which you're referring to security related concerns? Disabling showing errors in prod environments imo is a userland concern, implying that exception messages can't be extensive and clear enough. The current message does not really help much in solving the issue.

[rvanlaak]

The actual root cause of the issue was an entity having a is... method on a relationship, which potentially could be an issue on it's own?

#[ApiResource]
class Foo {

    private Bar $bar;

	public function isBar(): bool
	{
		// ...
	}
}

with the change of this PR would lead to

In AbstractItemNormalizer.php line 946:
                                                                               
  Unexpected non-object value for to-one relation on class `App\Domain\Foo` for attribute `bar`.                                             
                                                                               

[soyuka]

not sure, probably it should be hasBar ? I didn't make up the property accessor naming rules :p. How did you fix this in the end?
Could you target 4.2 for this patch?

[rvanlaak]

@soyuka ✅ rebase and targeting 4.2

[soyuka]

thanks!