Skip to content

dynamic settings may fail when slice involving #36

Description

@RocFang

Hello! @spacewander

Since https://hg.nginx.org/nginx/rev/d16ba0ea3434
Subrequests of slice module will bypass phases which come before content handler, and may trigger some confusing behaviors for some dynamic settiings, especialy proxy settings. For example #35 .

The safe way maybe set the according attributes of ngx_http_apisix_ctx_t again to ctx->sr right after ngx_http_subrequest in ngx_http_slice_filter_module.c .

It's not a bug report, just a mention.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    noteSomething important

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions