Fixes for Sphinx version 7.#75
Open
sayravai wants to merge 1 commit intoapluslms:masterfrom
Open
Conversation
18 tasks
ihalaij1
requested changes
Apr 7, 2026
Contributor
ihalaij1
left a comment
There was a problem hiding this comment.
Nice!
I tested this together with the a-plus-rst-tools PR.
I didn't notice any obvious issues with A+ manual.
I had just one question.
Comment on lines
474
to
476
|
|
||
| \ | ||
|
|
Contributor
There was a problem hiding this comment.
What is the purpose of this slash? Is it needed for some reason?
Contributor
Author
There was a problem hiding this comment.
I think it was to prevent compilation errors as the table cell was otherwise empty.
Contributor
Author
There was a problem hiding this comment.
Actually there was a self.assert_has_content() in directives > row.py, line 74 but as that was removed in my PR, this slash should no longer be required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some fixes to make compilation go through with Sphinx v7.4.7, which is apparently slightly stricter with the syntax, and no longer supports the master_doc setting. The master_doc to root_doc change was already made in Sphinx 4.0.0b1 so this should also compile with RST tools 1.4 (not tested).
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!