Skip to content

Fixes for Sphinx version 7.#75

Open
sayravai wants to merge 1 commit intoapluslms:masterfrom
sayravai:sphinx_7
Open

Fixes for Sphinx version 7.#75
sayravai wants to merge 1 commit intoapluslms:masterfrom
sayravai:sphinx_7

Conversation

@sayravai
Copy link
Copy Markdown
Contributor

@sayravai sayravai commented Mar 4, 2026

Description

Some fixes to make compilation go through with Sphinx v7.4.7, which is apparently slightly stricter with the syntax, and no longer supports the master_doc setting. The master_doc to root_doc change was already made in Sphinx 4.0.0b1 so this should also compile with RST tools 1.4 (not tested).

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

Copy link
Copy Markdown
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I tested this together with the a-plus-rst-tools PR.
I didn't notice any obvious issues with A+ manual.

I had just one question.

Comment thread point_of_interest/examples.rst Outdated
Comment on lines 474 to 476

\

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this slash? Is it needed for some reason?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was to prevent compilation errors as the table cell was otherwise empty.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there was a self.assert_has_content() in directives > row.py, line 74 but as that was removed in my PR, this slash should no longer be required.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the slash.

@ihalaij1 ihalaij1 self-assigned this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants