Skip to content

Fix/journal physical size - #924

Merged
jglogan merged 4 commits into
apple:mainfrom
siddh34:fix/journalPhysicalSize
Oct 2, 2026
Merged

jglogan merged 4 commits into
apple:mainfrom
siddh34:fix/journalPhysicalSize

Conversation

@siddh34

@siddh34 siddh34 commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

@dkovba splitting #832

@siddh34
siddh34 force-pushed the fix/journalPhysicalSize branch from 0d83e0b to 676ee6e Compare September 12, 2026 18:25
@siddh34
siddh34 force-pushed the fix/journalPhysicalSize branch from 676ee6e to 104efeb Compare September 23, 2026 04:40

@jglogan jglogan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddh34 Thanks for the contribution. Just one nit regarding setupJournalInode.

Comment thread Sources/ContainerizationEXT4/EXT4+Journal.swift Outdated
@siddh34
siddh34 force-pushed the fix/journalPhysicalSize branch from 7125cb3 to 9e323b0 Compare October 2, 2026 10:07
@siddh34
siddh34 requested a review from jglogan October 2, 2026 10:07

@jglogan jglogan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddh34 lgtm, and thank you for splitting the original PR!

@jglogan
jglogan merged commit db5ef7a into apple:main Oct 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants