Align how we log all system property values - #3578
Merged
Merged
Conversation
Motivation:
Align all props to use consistent pattern.
Modifications:
- Use `-D{}={}` pattern instead of `-D{}: {}` to help systems with
key-value log layout to show properties correctly as a single line.
- Add standard `DANGEROUS_CONFIG_WARNING` prefix where necessary.
- Update formatting and wording to keep things consistent.
Result:
System properties are logged in consistent format and easier to parse
for key-value logging systems.
bryce-anderson
approved these changes
Jul 21, 2026
| } | ||
| } | ||
| LOGGER.debug("{}={}", logLevelPropertyStr, logLevel); | ||
| LOGGER.debug("-D{}={}", logLevelPropertyStr, logLevel); |
Contributor
There was a problem hiding this comment.
Feel free to ignore: Not something you did in this PR, but in the throw case, logLevel will be null. While you're here do you want to change it to something else or is null obvious enough?
Member
Author
There was a problem hiding this comment.
Should be ok as-is, this is a super rate feature that is likely used only by us
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Align all props to use consistent pattern.
Modifications:
-D{}={}pattern instead of-D{}: {}to help systems with key-value log layout to show properties correctly as a single line.DANGEROUS_CONFIG_WARNINGprefix where necessary.Result:
System properties are logged in consistent format and easier to parse for key-value logging systems.