This repository was archived by the owner on Dec 21, 2023. It is now read-only.
Make coremltools python-dependent in requires_dist #3343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobyRoseman
reviewed
Oct 2, 2020
Makes the `coremltools` version explicitly dependent on the Python version in `install_requires`
malcolmgreaves
force-pushed
the
fix/python_versioning_for_coremltool
branch
from
7a45f39 to
d688a3b
Compare
3 tasks
malcolmgreaves
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
coremltoolsdependency depends on the user's Python version. The logic for specifying this already exists insetup.py. This PR makes thecoremltoolsversion explicitly dependent on the Python version in theinstall_requiresentry.This change fixes #3342 .