Use MPI_Dist_graph_create to determine comm pattern#1358
Merged
Conversation
Contributor
Author
|
Tested it on Frontier. Need to test it more thoroughly:
|
Rombur
reviewed
May 18, 2026
| dest_weights[i] = _dest_offsets[i + 1] - _dest_offsets[i]; | ||
|
|
||
| MPI_Comm graph_comm; | ||
| MPI_Dist_graph_create(_comm, (outdegree ? 1 : 0), &comm_rank, &outdegree, |
Collaborator
There was a problem hiding this comment.
Can we save the graph or do we need to rebuild it every time?
Contributor
Author
There was a problem hiding this comment.
Right now, we don't use it past Distributor construction. I do want to try to use it for neighborhood communications inside doPostsAndWaits in the future. I'll store it then if it works out.
04101b8 to
5afb287
Compare
Contributor
Author
|
Replaced OpenMPI with MPICH in the HIP build. |
Have trouble with hanging when run in a loop, see open-mpi/ompi#13918
6beb94d to
0e33f85
Compare
Contributor
Author
|
Switching HIP build from OpenMPI to MPICH results in very weird errors when building ArborX: Trying to see if the same thing happens with switching GCC build. |
87ed69f to
f9035d2
Compare
f9035d2 to
6e95a56
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MPI_Alltoallhas issues with scaling. This patch replaces it by usingMPI_Dist_graph_createand other helper functions to rely on MPI. This seems to scale better on Frontier:This bumps our MPI requirement to 2.2.
Also replaced OpenMPI with MPICH in the HIP build.
@dalg24 pointed out that we did something similar in ORNL-CEES/DataTransferKit#516. So this can be seen as a partial revert of that.