Feat/sources in react widget #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… widget, handled sources data.type, and rendering sources when available
…into feat/sources-in-react-widget
|
@utin-francis-peter is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…l to make theme props available globally
…into feat/sources-in-react-widget
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/sources-in-widget #1317 +/- ##
==========================================================
- Coverage 33.89% 33.36% -0.53%
==========================================================
Files 70 77 +7
Lines 3440 4127 +687
==========================================================
+ Hits 1166 1377 +211
- Misses 2274 2750 +476 ☔ View full report in Codecov by Sentry. |
…into feat/sources-in-react-widget
…into feat/sources-in-react-widget
ManishMadan2882
approved these changes
Feb 17, 2025
ManishMadan2882
merged commit 7989137
into
arc53:feat/sources-in-widget
8 of 9 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature in review.
Why was this change needed? (You can also link to an open issue here)
This update will make it possible for users to view the source of generated responses to their queries when interacting with the widget.
Other information:
After series of implementations through trials and research, the sources still refuses to render as expected. Please I'll appreciate some reviews of current implementation and helpful discussions around it. Thank you.
Also, there seems to be a bug I didn't account for in this PR, but pre the actual generated response, an "undefined" response is rendered into the bubble. On actual response rendering, the initial "undefined" text gets concatenated to the actual responses. I'm willing to make a PR after current issue is resolved.
closes: #1289