Feat: Zram algorithm config #4042
Conversation
archinstall/lib/args.py
Outdated
| packages: list[str] = field(default_factory=list) | ||
| parallel_downloads: int = 0 | ||
| swap: bool = True | ||
| swap: bool | dict[str, Any] = True |
There was a problem hiding this comment.
Perhaps we could swap Any here if possible.
There was a problem hiding this comment.
Yepp that looks correct (I say just looking at the code, haven't tested it)
There was a problem hiding this comment.
Will also test later tonight 👍
I like this (would) make the option in menu more useful than yes/no :D
|
Sorry about the messy commits, learning about the full structure still. Really do appreciate all the feedback from both of you. I will do more testing today. If you have the chance to look at the LVM branch I'd be really grateful too. |
No worries, we squish commits to one right before merging - so it'll look like one commit in the end :) |
| packages=['firefox'], | ||
| parallel_downloads=66, | ||
| swap=False, | ||
| swap=ZramConfiguration(enabled=False), |
There was a problem hiding this comment.
This should probably be test the true case with a proper algorithm
3 participants
Continuation to PR #4027
Would allow to set the algo of zram directly. Available ones can be checked using
cat /sys/block/zram0/comp_algorithmWe could however extend this to support re-compression as seen on the wiki
But for now already giving an option looks better.
untitled.mp4
This also fixes a quirk where the default highlighted value was "no" causing an extra interaction for sane default.