Implement Operations for Col in faer#653
Draft
cloudsftp wants to merge 20 commits into
Draft
Conversation
Author
|
Depends on #654 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds implementations of some operations for the Col vectors of the faer crate.
The operation implementations are mostly copied and adjusted from the code added in #575.
The implemented operations are enough for the GaussNewton solvers.
Why?
When implementing the Operator and Jacobian traits for some objective function, it is awkward to implement it with
type Param = Mat.The
Coltype is much better.The solver needs some operations to be implemented for
Col.I wanted to ask first, whether these changes are wanted, before continuing to implement other operations for the
Coltype that are required by other solvers.