Test Foundry methods independently - #1088
Merged
Merged
Conversation
runForgeTest combines per-method outcomes with and. This is suitable for suite-level CLI reporting, but too weak for tests that expect every selected method to have a specific result. An aggregate False only proves that at least one method failed, while an empty selection yields (True, True). Expose raw unit-test results to test helpers and assert non-empty, per-method outcomes for homogeneous regex and prefix selections. Use exact-name, single-result checks for individual and custom-option tests so similarly prefixed methods cannot affect results. Keep aggregate reduction only for the mixed-warning suite where it is intentional.
msooseth
marked this pull request as ready for review
September 7, 2026 09:05
msooseth
approved these changes
Sep 7, 2026
msooseth
left a comment
msooseth
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Let's merge if you are happy with this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
runForgeTest combines per-method outcomes with and. This is suitable for suite-level CLI reporting, but too weak for tests that expect every selected method to have a specific result. An aggregate False only proves that at least one method failed, while an empty selection yields (True, True).
Expose raw unit-test results to test helpers and assert non-empty, per-method outcomes for homogeneous regex and prefix selections. Use exact-name, single-result checks for individual and custom-option tests so similarly prefixed methods cannot affect results. Keep aggregate reduction only for the mixed-warning suite where it is intentional.
Checklist