perf: make keccak preimage recording optional and strict - #1090
Merged
Conversation
Concrete Keccak recorded every preimage in vm.keccakPreImgs with a lazy modifying, building an unforced chain of Set inserts that retains every hashed buffer for the VM's lifetime. The set is only consumed when symbolic execution continues from the state (keccak constraints for the solver), so purely concrete users pay for nothing they use. Gate the recording behind RuntimeConfig.recordKeccakPreImgs (default True, preserving existing behavior) and force the insert when it does happen. Benchmark: Echidna fuzzing a real-world Foundry project (1 workers, 15k calls plus corpus replay) with this commit and the consumer setting the flag to False: GC time 2.89s -> 2.02s, bytes copied during GC -1.8 GB, mutator time -0.4s.
Collaborator
Author
All benchmarks |
blishko
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Concrete Keccak recorded every preimage in vm.keccakPreImgs with a lazy modifying, building an unforced chain of Set inserts that retains every hashed buffer for the VM's lifetime. The set is only consumed when symbolic execution continues from the state (keccak constraints for the solver), so purely concrete users pay for nothing they use.
Gate the recording behind RuntimeConfig.recordKeccakPreImgs (default True, preserving existing behavior) and force the insert when it does happen.
Benchmark: Echidna fuzzing a real-world Foundry project (1 workers, 15k calls plus corpus replay) with this commit and the consumer setting the flag to False: GC time 2.89s -> 2.02s, bytes copied during GC -1.8 GB, mutator time -0.4s.
Checklist