[#21] bash completion simplification#22
Merged
Merged
Conversation
Revisiting the autocompletion to make it easier to read and maintain.
Instead of a list of monolithic test functions move all the tests cases in a json file and use a test framework to execute them all.
brusdev
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally written with AI without much supervision, the bash completion & test suite was full of boilerplate and duplicated code. Using help of the AI once more, I rewrote the completion code so that it's human readable. Same goes for the test suite that went from an awful 5K lines of bash to a simple test framework of approximately 400 lines of bash + json data.