Skip to content

rockchip64-7.2: drop general-rk3588-i2s-mclk-output-gate-5-ignore-unused as it was merged upstream - #10452

Closed
rpardini wants to merge 1 commit into
armbian:mainfrom
rpardini:pr/rockchip64-72-drop-general-rk3588-i2s-mclk-output-gate-5-ignore-unused-as-it-was-merged-upstream
Closed

rockchip64-7.2: drop general-rk3588-i2s-mclk-output-gate-5-ignore-unused as it was merged upstream#10452
rpardini wants to merge 1 commit into
armbian:mainfrom
rpardini:pr/rockchip64-72-drop-general-rk3588-i2s-mclk-output-gate-5-ignore-unused-as-it-was-merged-upstream

Conversation

@rpardini

@rpardini rpardini commented Aug 17, 2026

Copy link
Copy Markdown
Member
  • 🌴 very last minute before v7.2 (-final), but, thankfully

Summary by CodeRabbit

  • Bug Fixes
    • Preserved firmware-enabled I2S master clock outputs on Rockchip RK3588 systems.
    • Prevented unused-clock cleanup from disabling required audio clock gates.

…sed as it was merged upstream

- very last minute before v7.2 (-final), but, thankfully
@github-actions github-actions Bot added size/medium PR with more then 50 and less then 250 lines 08 Milestone: Third quarter release labels Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5dada0ab-002f-41ae-8086-7a3701127680

📥 Commits

Reviewing files that changed from the base of the PR and between 2db577f and 06bd323.

📒 Files selected for processing (1)
  • patch/kernel/archive/rockchip64-7.2/general-rk3588-i2s-mclk-output-gate-5-ignore-unused.patch
💤 Files with no reviewable changes (1)
  • patch/kernel/archive/rockchip64-7.2/general-rk3588-i2s-mclk-output-gate-5-ignore-unused.patch

Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The RK3588 clock definitions add CLK_IGNORE_UNUSED to four I2S MCLK output-to-I/O gates.

Changes

Cohort / File(s) Summary
RK3588 I2S MCLK gates
patch/kernel/archive/rockchip64-7.2/general-rk3588-i2s-mclk-output-gate-5-ignore-unused.patch
Updates four clock gate definitions so unused-clock disabling does not disable firmware-enabled gates.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 06bd3

This change removes a single obsolete kernel patch and introduces no actionable merge-blocking risk beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states that the upstream-merged Rockchip patch is being removed from the 7.2 patch set.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SuperKali SuperKali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪🎉

@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Aug 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Aug 17, 2026
@EvilOlaf

Copy link
Copy Markdown
Member

cherry-picked into #10448

@EvilOlaf EvilOlaf closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines

Development

Successfully merging this pull request may close these issues.

3 participants